Support for SQL Server #543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed support for python 3.7 * Added common and dialects packages to handle the new SQLAlchemy 2.0+
* The connections were hanging sometimes during the tests.
* Revert changes automatically applied by IDE * Fix formatting of CI caused by IDE changes * Codebase cleanup for SQLAlchemy 2.0 * Fix EOL in mkdocs
tarsil
force-pushed
the
feature/support_for_sqlserver
branch
from
9ebd2b1
to
d48766e
Compare
|
@Kludex any reason why the CI is taking so long? Locally all the tests pass with flying colours |
tarsil
force-pushed
the
feature/support_for_sqlserver
branch
2 times, most recently
from
34234bb
to
ef8cdff
Compare
tarsil
force-pushed
the
feature/support_for_sqlserver
branch
from
ef8cdff
to
f87e1b3
Compare
tarsil
force-pushed
the
feature/support_for_sqlserver
branch
from
3814528
to
b0eae59
Compare
tarsil
force-pushed
the
feature/support_for_sqlserver
branch
from
2cdd1b1
to
9c3c606
Compare
tarsil
force-pushed
the
feature/support_for_sqlserver
branch
from
9c3c606
to
121dc66
Compare
|
Closing this one as it took a lot of try and error with the CI and opening a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aminalaee @Kludex
This is a PR proposing support for SQL Server. A lot of companies still use it and with
aioodbcand databases patterns, this was possible to achieve as well. This could be merged maybe after this one? The reason why after its only because I branched off that branch to create this new one and once it's merged, it is way less files to review.