Integrating SQLALchemy 2.0 #539
Conversation
* Update aiopg to be compliant with asyncpg
* Removed references in the code for aiopg * Created custom dialect for psycopg * Fixed tests async_adapter to get the event loop
* Old codebase remained as is
|
Weird, locally it was passing but I was using Postgres only to be honest. Hmm, it would be great to have some suggestions. As I mentioned before, didn't have too much time on this, unfortunately. |
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
* Moved common functions to a common package * Created common Record for the DB supported
* Add docker-compose.yml for local development * Added Makefile for local automations
|
|
||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). |
There was a problem hiding this comment.
I think the PR is getting way too big, for no reason. can we please stick only to necessary changes?
For example I think CHANGELOG.md is consistent withing all encode projects.
* Added new pg compiler * Updated tests
|
@Kludex and @aminalaee I can put back the changelog to the way it was. I just thought it was to be consistent with Starlette and other products. Usually when people go after docs, having the release notes there helps. I'm just fixing some of the issues with the CI and this should be ok. I was able to reintegrate with aiopg as well and the changes themselves not only cleans but also updates a lot of things based on SQLAlchemy 2.0 |
|
I will check what is happening here with the CI and then I will close this PR and open a clean new one @aminalaee and @Kludex |
|
Opening a brand new and cleaner PR |
Attention
@Kludex and @aminalaee - I didn't have a lot of time recently and this, at least locally, was passing the current tests