Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.6 #458

Merged
merged 6 commits into from May 30, 2022
Merged

Drop Python 3.6 #458

merged 6 commits into from May 30, 2022

Conversation

aminalaee
Copy link
Member

Dropping Python3.6 and setting minimum version to Python 3.7

@aminalaee aminalaee linked an issue Feb 1, 2022 that may be closed by this pull request
@aminalaee aminalaee mentioned this pull request Feb 1, 2022
@collerek
Copy link
Member

collerek commented Feb 7, 2022

@aminalaee This requires changes in checks - 3.6. should be removed from required runs.

@aminalaee
Copy link
Member Author

The checks are updated for future PRs but since this PR's base branch has that check I think only the maintainer access can merge this. Maybe @tomchristie can help here.

@collerek
Copy link
Member

The checks are updated for future PRs but since this PR's base branch has that check I think only the maintainer access can merge this. Maybe @tomchristie can help here.

Yep, I believe you need access to settings -> branches to disable it.
So we indeed need @tomchristie help with that.
Maybe disable all of them, we don't merge anything that fails any of the runs anyway?

@aminalaee aminalaee mentioned this pull request May 29, 2022
@collerek
Copy link
Member

@Kludex can you adjust the settings of this repository and uncheck the required checks status in the branches settings of databases? We cannot merge it since it stills requires python 3.6 check for a branch that removes it.

@aminalaee
Copy link
Member Author

@collerek He mentioned in gitter that only @tomchristie can do that

@collerek
Copy link
Member

Ah, ok. Saw the operations group in encode and by the description I thought all members can manage repository settings

@aminalaee aminalaee merged commit 17b03a4 into master May 30, 2022
@aminalaee aminalaee deleted the drop-python3.6 branch May 30, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing Python 3.6
3 participants