New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows compatibility for tests #454

Open

collerek wants to merge 3 commits into master from add-windows-compatibility-for-tests

Member

collerek commented Jan 25, 2022

Add windows support for tests:

different path to venv scripts
aiopg needs a workaround with event loop setting on py3.8+

Should be reviewed after #453 is merged to highlight only relevant changes

collerek added 2 commits

January 25, 2022 12:57


          add support for local tests in docker

6e36535


          update docs

002e579

collerek requested a review from aminalaee

January 25, 2022 17:36


          Merge branch 'master' into add-windows-compatibility-for-tests

175be5a

collerek mentioned this pull request

Add contributing docs #453

Merged

Member

aminalaee commented Feb 1, 2022

Let's wait for the base branch to be dealt with so we can review this. But I like the windows compatibility approach anyway.

Maybe we can also add it to the GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment