Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow iterating over custom number of records with asyncpg #414

Closed
wants to merge 9 commits into from
Closed

allow iterating over custom number of records with asyncpg #414

wants to merge 9 commits into from

Conversation

databasedav
Copy link

@databasedav databasedav commented Oct 27, 2021

addresses #413, but only for postgres with asyncpg, passing n in the kwargs to .iterate will error for the other drivers, i can add them eventually if that's a requirement to get this merged

  • asyncpg
  • tests
  • other drivers
  • documentation

@aminalaee
Copy link
Member

@databasedav Thank you for this.
yes, I think the idea is to have the same thing for all backends.
And you can also add documentation to your checklist.

@databasedav
Copy link
Author

looks like some of the backends might not be breaking out of the while fetchmany loop, @aminalaee can you please disable the github actions, i'll comment once i figure the others out, thanks

@aminalaee
Copy link
Member

@databasedav I've cancelled the previous actions, if that's what you mean. But I can't disable them in the project.
Sure, take your time and fix them in your local.

@databasedav
Copy link
Author

@aminalaee yup that's what i meant, thanks again

@aminalaee
Copy link
Member

Any update with this?

@databasedav
Copy link
Author

i was having issue with running these concurrently, i think it was related to the transaction issues mentioned in the repo, i am now just using sqlalchemy since it has asyncpg support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants