Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.4.3 #314

Merged
merged 6 commits into from
Mar 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## 0.4.3 (March 26th, 2021)

### Fixed

* Pin SQLAlchemy to 1.13.* (#314)

## 0.4.2 (March 14th, 2021)

### Fixed
Expand Down Expand Up @@ -34,4 +40,3 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
* Fix SQLAlchemy DDL statements (#226)
* Make fetch_val call fetch_one for type conversion (#246)
* Unquote username and password in DatabaseURL (#248)

2 changes: 1 addition & 1 deletion databases/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from databases.core import Database, DatabaseURL

__version__ = "0.4.2"
__version__ = "0.4.3"
__all__ = ["Database", "DatabaseURL"]
3 changes: 1 addition & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
# Notes...
# The JSONField tests require sqlalchemy 1.3+. Other cases work at lower versions.
# The aiocontextvars package is only required as a backport for Python 3.6.
sqlalchemy>=1.3.0
aiocontextvars;python_version<"3.7"
-e .

# Async database drivers
aiomysql
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def get_packages(package):
packages=get_packages("databases"),
package_data={"databases": ["py.typed"]},
data_files=[("", ["LICENSE.md"])],
install_requires=["sqlalchemy", 'aiocontextvars;python_version<"3.7"'],
install_requires=['sqlalchemy<1.4', 'aiocontextvars;python_version<"3.7"'],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomchristie sorry to bother. I'm running into problems because of this. Any insight into when sqlalchemy>1.3 will be supported? What can I possibly do to help?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure - I've not personally got the extra time for this at the moment.
There's some work on supporting 1.4 in #299 - You might want to start by trying that out locally and confirming if it works for you, and if it does then helping review any remaining points that's blocking that pull request from being accepted.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

extras_require={
"postgresql": ["asyncpg"],
"mysql": ["aiomysql"],
Expand Down