Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query result named access #448

Merged
merged 1 commit into from Jan 20, 2022
Merged

Fix query result named access #448

merged 1 commit into from Jan 20, 2022

Conversation

aminalaee
Copy link
Member

The SQLAlchemy Row already implements __getattr__ through BaseRow so if we add it to asyncpg Record then it should be ok for all drivers.

@aminalaee aminalaee requested review from collerek and a team January 19, 2022 20:16
@aminalaee aminalaee changed the title Fix result named access Fix query result named access Jan 20, 2022
@aminalaee aminalaee merged commit e28a8d9 into master Jan 20, 2022
@aminalaee aminalaee deleted the fix-result-named-access branch January 20, 2022 08:55
@aminalaee aminalaee mentioned this pull request Jan 20, 2022
Merged
@aminalaee aminalaee mentioned this pull request May 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmarkovtsev vmarkovtsev vmarkovtsev approved these changes

@collerek collerek Awaiting requested review from collerek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aminalaee @vmarkovtsev