WRN-18693: Update testing library rules #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recommended changes in eslint 8)
MikyungKim
reviewed
Mar 25, 2022
@MikyungKim |
MikyungKim
changed the title
MikyungKim
reviewed
Apr 20, 2022
MikyungKim
reviewed
Apr 29, 2022
index.js
Outdated
| 'testing-library/no-dom-import': ['error', 'react'], | ||
| 'testing-library/no-node-access': 'off', |
There was a problem hiding this comment.
Can we just remove it? Should we "off" this?
There was a problem hiding this comment.
Either is fine, let's remove it.
MikyungKim
reviewed
Apr 29, 2022
strict.js
Outdated
| @@ -43,13 +43,13 @@ module.exports = { | |||
| 'no-array-constructor': 'error', | |||
| 'no-cond-assign': ['error', 'except-parens'], | |||
| 'no-console': 'warn', | |||
| 'no-debugger': 'warn', | |||
| 'no-debugger': 'error', | |||
There was a problem hiding this comment.
If these warn to error rules in the eslint:recommended, can we just remove them?
There was a problem hiding this comment.
OK, let's remove it.
Not exactly, but before eslint 6.0.0(before May 2019), eslint:recommend already set 'no-debugger' to 'error'.
(eslint/eslint@f42d0af)
MikyungKim
reviewed
Apr 29, 2022
index.js
Outdated
| @@ -235,7 +235,7 @@ module.exports = { | |||
| '**/?(*.)+(spec|test).[jt]s?(x)', | |||
There was a problem hiding this comment.
Please update the glob pattern.
|
Closing this in favor of #49. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Resolved / Feature Added
Update lint rules of testing
Resolution
Update lint rules of testing
Additional Considerations
Links
WRN-18693
Comments
Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)