Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAT-53066: Update camelcase rule for ^UNSAFE_ react lifecycle methods #24

Merged
merged 2 commits into from Jan 21, 2019
Merged

PLAT-53066: Update camelcase rule for ^UNSAFE_ react lifecycle methods #24

merged 2 commits into from Jan 21, 2019

Conversation

viodragon2
Copy link
Contributor

@viodragon2 viodragon2 commented Jan 17, 2019 •
edited

See also

https://eslint.org/docs/rules/camelcase#allow

Enact-DCO-1.0-Signed-off-by: Stephen Choi stephen.choi@lge.com

webOS101
webOS101 approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@webOS101 webOS101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JayCanuck JayCanuck merged commit 2d8a0da into master Jan 21, 2019
@JayCanuck JayCanuck deleted the feature/PLAT-53066-stephen branch January 21, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webOS101 webOS101 webOS101 approved these changes

@JayCanuck JayCanuck JayCanuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@viodragon2 @webOS101 @JayCanuck