PLAT-44298: Resolve serving issues #89
Conversation
…r development config.
…quired for isomorphic builds. Alternatively, in the serve command, modify the config to not use the extract-text-webpack-plugin.
…g for loaders by name.
| @@ -186,7 +186,8 @@ module.exports = { | |||
| 'last 4 versions', | |||
| 'Firefox ESR', | |||
| 'not ie < 9' // React doesn't support IE8 anyway. | |||
| ] | |||
| ], | |||
| flexbox: 'no-2009' | |||
There was a problem hiding this comment.
What's up with this change?
There was a problem hiding this comment.
It was a prop that was accidentally omitted last release (change already exists within production config). Just brings up to parity.
| const enact = require(path.resolve('./package.json')).enact || {}; | ||
| const autoprefixer = require('autoprefixer'); | ||
| const LessPluginRi = require('resolution-independence'); | ||
| config.module.rules[4] = { |
There was a problem hiding this comment.
Can we "find" the index here (and below) rather than hard coding it? Might save us from accidentally breaking this without noticing.
There was a problem hiding this comment.
Not easily given the loader name itself is dynamic generated from extract-text-plugin. If we want a more complex detection system I can implement that, though given we control the config and this is solely a serve fix for an issue actively being worked on by the webpack team, the impact potential is very very small. Probably will be removed next enact-dev update.
Remove ExtractTextPlugin usage in development builds to avoid webpack-contrib/extract-text-webpack-plugin#579 It's not necessary in development phase of lifecycle anyway.
Additionally updated the configs to use relative package-level loaders.
Enact-DCO-1.0-Signed-off-by: Jason Robitaille jason.robitaille@lge.com