Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make local development & babel plugin hashing compatible with Windows #910

Merged
merged 3 commits into from Oct 10, 2018

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Oct 10, 2018

Extracted from #886

This is more important than setting up AppVeyor to test compat automatically and we have perf concerns about that CI, so I'll try to experiment with speeding things up there in that other PR.

Let's merge this independently though :)

Resolves #881.

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #910 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
...-plugin-emotion/src/utils/get-target-class-name.js 100% <100%> (ø) ⬆️

@emmatown emmatown merged commit be0515a into master Oct 10, 2018
@emmatown emmatown deleted the windows-compat branch October 10, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants