Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fetchpriority to props #3093

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add fetchpriority to props #3093

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7953b6
Added fetchpriority to props
DustinBrett Aug 15, 2023
11d6b45
Add fetchPriority as well
DustinBrett Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/is-prop-valid/src/props.js
View file
Open in desktop
Expand Up @@ -69,6 +69,8 @@ const props = {
draggable: true,
encType: true,
enterKeyHint: true,
fetchpriority: true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this even valid?

Suggested change
fetchpriority: true,

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends what you mean by valid, but I would say likely yes. I use this and it does indeed function and have an effect in browsers. The links I provided in the description also use it this way.

image

Also checking the way this list is used, it seemed to me that both versions should be added as I saw nothing to turn the camel case version into lower case.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the handling of uppercase vs. lowercase confuses me a bit in @emotion/is-prop-valid.

References:

Maybe we should actually .toLowerCase() when determining if a prop should be forwarded or not.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya it's possible converting to lower case could be useful. I didn't see many duplicates. For my use case with Styled Components, it currently passes without the capitol. So I think it would be needed for this PR to stop my warning. The camel case version is not one I've had to use with React yet.

fetchPriority: true,
form: true,
formAction: true,
formEncType: true,
Expand Down