Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minifying keyframes #3053

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

kishlayraj-9
Copy link

@kishlayraj-9 kishlayraj-9 commented Jun 12, 2023

What: Keyframes are now minified in production build, which were not earlier.

Why: Production build should always contain minified code so that resultant bundle size is minimum.

How: -> Changes in the minify function of minify-utils.js file of babel-plugin-emotion.
-> Addition of one new file i.e. macro.js file in @emotion/core.

Note - Now, users need to import keyframe from @emotion/core/macro by using the following import,
   "import  {keyframes} from '@emotion/core/macro' ".

Checklist:

  • Documentation
  • Tests
  • Code complete
  • Changeset

@changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2023

🦋 Changeset detected

Latest commit: 4d28109

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@emotion/core Major
babel-plugin-emotion Major
emotion-theming Major
@emotion/primitives-core Major
@emotion/styled-base Major
@emotion/styled Major
@emotion/native Major
@emotion/primitives Major
@emotion/babel-preset-css-prop Major
@emotion/css Major
emotion-server Major
emotion Major
benchmarks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kishlayraj-9 kishlayraj-9 marked this pull request as draft June 13, 2023 09:21
@kishlayraj-9 kishlayraj-9 marked this pull request as ready for review June 13, 2023 10:08
@kishlayraj-9 kishlayraj-9 marked this pull request as draft June 13, 2023 10:10
@kishlayraj-9 kishlayraj-9 marked this pull request as ready for review June 13, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant