Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ssr.mdx #2994

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update ssr.mdx #2994

wants to merge 1 commit into from

Conversation

zkuzmic
Copy link

@zkuzmic zkuzmic commented Feb 15, 2023

What: Clarify documentation on SSR page

Why: The current wording makes it seem as if only the "Advanced Approach" does not support React 18 streaming APIs when in reality, emotion doesn't support those APIs at all (regardless of approach). See #2800

How: Added a note at the top of the doc page that indicates the above more clearly.

Checklist:

  • Documentation
  • Tests N/A
  • Code complete N/A
  • Changeset N/A

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2023

⚠️ No Changeset found

Latest commit: 856f63e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 856f63e:

Sandbox Source
Emotion Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant