Encourage creating globals outside render cycle #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our large app, we noticed a 50% reduction in render time when moving our tagged template literal outside of the render cycle. See flame chart [here](ParabolInc/parabol#7598 (comment)). Hopefully making this change in the docs encourages others to do the same!
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 28f6dc9:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
In our large app, we noticed a 50% reduction in render time when moving our tagged template literal outside of the render cycle.
Hopefully making this change in the docs encourages others to do the same!
cc @BartoszJarocki for discovering this
Why:
a 50% reduction in render time for large apps.
See flame chart here.
How:
Global styles usually live at the top of the render tree. Saving 1ms on every render can add up substantially!
Checklist: