Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added '@emotion/react' ESLint config #2960

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoshuaKGoldberg
Copy link
Contributor

What:

Adds a new @emotion/react preset ESLint config users can extend from:

{
  "extends": ["@emotion/react"],
  "plugins": ["@emotion"]
}

It enables the relevant ESLint rules related to React.

Why:

How:

  • Adds the exported config as an object
  • Updates the eslint-plugin README.md docs to mention it
  • Sorts rules alphabetically wherever they're listed 馃槇

Checklist:

  • Documentation
  • Tests
  • Code complete
  • Changeset

Is there a way you'd like me to include tests for this change?

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2022

馃 Changeset detected

Latest commit: 8880e80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/eslint-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8880e80:

Sandbox Source
Emotion Configuration

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #2960 (8880e80) into main (acb72a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage 螖
packages/eslint-plugin/src/index.js 100.00% <100.00%> (酶)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant