New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Yarn 3 (attempt 3) #2841
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a7993c2:
|
I think that it should be compatible with node_modules linker but I might be mistaken. You could try to use The patch is needed for updating inline snapshots and I don't think that the issue has been solved in Jest yet so we might need to bring this patch back. |
- [Node.js](http://nodejs.org/) >= v7 must be installed. | ||
- [Yarn](https://yarnpkg.com/en/docs/install) | ||
- [Node.js](http://nodejs.org/) >= v16 must be installed. | ||
- We are using Yarn Modern so you need either a global install of Yarn v1 (`npm i -g yarn`) or you need to [enable Corepack](https://yarnpkg.com/getting-started/install). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never have seen it being called "Yarn Modern", I think they usually refer to it as "Yarn Berry":
- We are using Yarn Modern so you need either a global install of Yarn v1 (`npm i -g yarn`) or you need to [enable Corepack](https://yarnpkg.com/getting-started/install). | |
- We are using Yarn Berry so you need either a global install of Yarn v1 (`npm i -g yarn`) or you need to [enable Corepack](https://yarnpkg.com/getting-started/install). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "Berry" is something of a codename. See here where they call it Yarn Modern.
5b81346
to
a7993c2
Compare
Hmm, Anyway, I added the patch using the native Yarn 3 patching feature. Let me know if it works for you. |
According to this comment you should try to add a new Since the patch has been re-added there isn't a strong need to spend time verifying if it's needed though. |
Previous attempt at this: #2657
Benefits
node_modules
, not Plug'n'Play, so this upgrade didn't break anything in the repository.Misc Notes
jest-snapshot
package patch because I don't thinkpatch-package
is compatible with Yarn 3. Removing the patch doesn't seem to have caused any problems though??ssr-benchmarks
project — it had an import which stopped working when we added theexports
field topackage.json
, I think.opencollective postinstall
frompostinstall
script since the output does not actually get printed to stdout when using Yarn 3.