Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dtslint #2653

Merged
merged 2 commits into from Feb 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -213,7 +213,7 @@
"bundlesize": "^0.13.2",
"codecov": "^2.3.1",
"cssjanus": "^1.2.0",
"dtslint": "^0.3.0",
"dtslint": "^4.2.1",
"enzyme": "^3.11.0",
"enzyme-adapter-react-16": "^1.15.5",
"enzyme-to-json": "^3.6.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/cache/package.json
Expand Up @@ -23,7 +23,8 @@
},
"devDependencies": {
"@emotion/hash": "*",
"dtslint": "^0.3.0"
"dtslint": "^4.2.1",
"typescript": "^4.5.5"
},
"publishConfig": {
"access": "public"
Expand Down
4 changes: 0 additions & 4 deletions packages/cache/types/tsconfig.json
Expand Up @@ -6,11 +6,7 @@
"lib": ["es6", "dom"],
"module": "commonjs",
"noEmit": true,
"noImplicitAny": true,
"noImplicitThis": true,
"strict": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"target": "es5",
"typeRoots": ["../"],
"types": []
Expand Down
3 changes: 2 additions & 1 deletion packages/css/package.json
Expand Up @@ -34,7 +34,8 @@
},
"devDependencies": {
"@babel/core": "^7.13.10",
"dtslint": "^0.3.0"
"dtslint": "^4.2.1",
"typescript": "^4.5.5"
},
"author": "Kye Hohenberger",
"homepage": "https://emotion.sh",
Expand Down
4 changes: 0 additions & 4 deletions packages/css/types/tsconfig.json
Expand Up @@ -6,11 +6,7 @@
"lib": ["es6", "dom"],
"module": "commonjs",
"noEmit": true,
"noImplicitAny": true,
"noImplicitThis": true,
"strict": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"target": "es5",
"typeRoots": ["../"],
"types": []
Expand Down
3 changes: 2 additions & 1 deletion packages/hash/package.json
Expand Up @@ -19,7 +19,8 @@
"test:typescript": "dtslint types"
},
"devDependencies": {
"dtslint": "^0.3.0"
"dtslint": "^4.2.1",
"typescript": "^4.5.5"
},
"browser": {
"./dist/emotion-hash.cjs.js": "./dist/emotion-hash.browser.cjs.js",
Expand Down
4 changes: 0 additions & 4 deletions packages/hash/types/tsconfig.json
Expand Up @@ -5,11 +5,7 @@
"lib": ["es6", "dom"],
"module": "commonjs",
"noEmit": true,
"noImplicitAny": true,
"noImplicitThis": true,
"strict": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"target": "es5",
"typeRoots": ["../"],
"types": []
Expand Down
3 changes: 2 additions & 1 deletion packages/is-prop-valid/package.json
Expand Up @@ -17,7 +17,8 @@
"@emotion/memoize": "^0.7.4"
},
"devDependencies": {
"dtslint": "^0.3.0"
"dtslint": "^4.2.1",
"typescript": "^4.5.5"
},
"files": [
"src",
Expand Down
4 changes: 0 additions & 4 deletions packages/is-prop-valid/types/tsconfig.json
Expand Up @@ -5,11 +5,7 @@
"lib": ["es6", "dom"],
"module": "commonjs",
"noEmit": true,
"noImplicitAny": true,
"noImplicitThis": true,
"strict": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"target": "es5",
"typeRoots": ["../"],
"types": []
Expand Down
5 changes: 3 additions & 2 deletions packages/jest/package.json
Expand Up @@ -39,13 +39,14 @@
"@emotion/css": "11.7.1",
"@emotion/react": "11.8.1",
"@types/jest": "^27.0.3",
"dtslint": "^0.3.0",
"dtslint": "^4.2.1",
"enzyme-to-json": "^3.6.1",
"preact": "^8.2.9",
"preact-render-to-json": "^3.6.6",
"pretty-format": "^22.4.3",
"react": "16.14.0",
"react-dom": "16.14.0"
"react-dom": "16.14.0",
"typescript": "^4.5.5"
},
"author": "Kye Hohenberger",
"homepage": "https://emotion.sh",
Expand Down
4 changes: 0 additions & 4 deletions packages/jest/types/tsconfig.json
Expand Up @@ -6,11 +6,7 @@
"lib": ["es6", "dom"],
"module": "commonjs",
"noEmit": true,
"noImplicitAny": true,
"noImplicitThis": true,
"strict": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"target": "es5",
"types": []
},
Expand Down
3 changes: 2 additions & 1 deletion packages/memoize/package.json
Expand Up @@ -14,7 +14,8 @@
"access": "public"
},
"devDependencies": {
"dtslint": "^0.3.0"
"dtslint": "^4.2.1",
"typescript": "^4.5.5"
},
"files": [
"src",
Expand Down
4 changes: 0 additions & 4 deletions packages/memoize/types/tsconfig.json
Expand Up @@ -5,11 +5,7 @@
"lib": ["es6", "dom"],
"module": "commonjs",
"noEmit": true,
"noImplicitAny": true,
"noImplicitThis": true,
"strict": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"target": "es5",
"typeRoots": ["../"],
"types": []
Expand Down
5 changes: 3 additions & 2 deletions packages/native/package.json
Expand Up @@ -17,9 +17,10 @@
"devDependencies": {
"@babel/core": "^7.13.10",
"@types/react-native": "^0.63.2",
"dtslint": "^0.3.0",
"dtslint": "^4.2.1",
"react": "16.14.0",
"react-native": "^0.63.2"
"react-native": "^0.63.2",
"typescript": "^4.5.5"
},
"dependencies": {
"@emotion/primitives-core": "^11.0.0"
Expand Down
4 changes: 2 additions & 2 deletions packages/native/types/tests.tsx
Expand Up @@ -23,9 +23,9 @@ declare module '@emotion/react' {
const cssObject = {
height: 100,
width: '100%',
display: 'flex',
display: 'flex' as const,
srmagura marked this conversation as resolved.
Show resolved Hide resolved
position: undefined
} as const
}

const className = css`
${(true as boolean) && ''}
Expand Down
7 changes: 2 additions & 5 deletions packages/native/types/tsconfig.json
Expand Up @@ -6,14 +6,11 @@
"lib": ["es6", "dom"],
"module": "commonjs",
"noEmit": true,
"noImplicitAny": true,
"noImplicitThis": true,
"strict": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"target": "es5",
"typeRoots": ["../"],
"types": []
"types": [],
"skipLibCheck": true
srmagura marked this conversation as resolved.
Show resolved Hide resolved
},
"include": ["./*.ts", "./*.tsx"]
}
5 changes: 3 additions & 2 deletions packages/react/package.json
Expand Up @@ -54,10 +54,11 @@
"@emotion/server": "11.4.0",
"@emotion/styled": "11.8.1",
"@types/react": "^16.9.11",
"dtslint": "^0.3.0",
"dtslint": "^4.2.1",
"html-tag-names": "^1.1.2",
"react": "16.14.0",
"svg-tag-names": "^1.1.1"
"svg-tag-names": "^1.1.1",
"typescript": "^4.5.5"
},
"repository": "https://github.com/emotion-js/emotion/tree/main/packages/react",
"publishConfig": {
Expand Down
4 changes: 0 additions & 4 deletions packages/react/types/tsconfig.json
Expand Up @@ -6,11 +6,7 @@
"lib": ["es6", "dom"],
"module": "commonjs",
"noEmit": true,
"noImplicitAny": true,
"noImplicitThis": true,
"strict": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"target": "es5",
"typeRoots": ["../"],
"types": []
Expand Down
3 changes: 2 additions & 1 deletion packages/serialize/package.json
Expand Up @@ -21,7 +21,8 @@
"csstype": "^3.0.2"
},
"devDependencies": {
"dtslint": "^0.3.0"
"dtslint": "^4.2.1",
"typescript": "^4.5.5"
},
"files": [
"src",
Expand Down
4 changes: 0 additions & 4 deletions packages/serialize/types/tsconfig.json
Expand Up @@ -6,11 +6,7 @@
"lib": ["es6", "dom"],
"module": "commonjs",
"noEmit": true,
"noImplicitAny": true,
"noImplicitThis": true,
"strict": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"target": "es5",
"typeRoots": ["../"],
"types": []
Expand Down
3 changes: 2 additions & 1 deletion packages/server/package.json
Expand Up @@ -32,7 +32,8 @@
"@emotion/css": "11.7.1",
"@emotion/css-prettifier": "1.0.1",
"@types/node": "^10.11.4",
"dtslint": "^0.3.0"
"dtslint": "^4.2.1",
"typescript": "^4.5.5"
},
"author": "Kye Hohenberger",
"homepage": "https://emotion.sh",
Expand Down
7 changes: 2 additions & 5 deletions packages/server/types/tsconfig.json
Expand Up @@ -6,14 +6,11 @@
"lib": ["es6"],
"module": "commonjs",
"noEmit": true,
"noImplicitAny": true,
"noImplicitThis": true,
"strict": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"target": "es5",
"typeRoots": ["../"],
"types": []
"types": [],
"skipLibCheck": true
},
"include": ["./*.ts", "./*.tsx"]
}
3 changes: 2 additions & 1 deletion packages/sheet/package.json
Expand Up @@ -23,6 +23,7 @@
"types/*.d.ts"
],
"devDependencies": {
"dtslint": "^0.3.0"
"dtslint": "^4.2.1",
"typescript": "^4.5.5"
}
}
4 changes: 0 additions & 4 deletions packages/sheet/types/tsconfig.json
Expand Up @@ -6,11 +6,7 @@
"lib": ["es6", "dom"],
"module": "commonjs",
"noEmit": true,
"noImplicitAny": true,
"noImplicitThis": true,
"strict": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"target": "es5",
"typeRoots": ["../"],
"types": []
Expand Down
5 changes: 3 additions & 2 deletions packages/styled/package.json
Expand Up @@ -33,8 +33,9 @@
"devDependencies": {
"@babel/core": "^7.13.10",
"@emotion/react": "11.8.1",
"dtslint": "^0.3.0",
"react": "16.14.0"
"dtslint": "^4.2.1",
"react": "16.14.0",
"typescript": "^4.5.5"
},
"publishConfig": {
"access": "public"
Expand Down
4 changes: 0 additions & 4 deletions packages/styled/types/tsconfig.json
Expand Up @@ -7,11 +7,7 @@
"lib": ["es6", "dom"],
"module": "commonjs",
"noEmit": true,
"noImplicitAny": true,
"noImplicitThis": true,
"strict": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"target": "es5",
"typeRoots": ["../"],
"types": []
Expand Down
3 changes: 2 additions & 1 deletion packages/utils/package.json
Expand Up @@ -23,6 +23,7 @@
"types/*.d.ts"
],
"devDependencies": {
"dtslint": "^0.3.0"
"dtslint": "^4.2.1",
"typescript": "^4.5.5"
}
}
4 changes: 0 additions & 4 deletions packages/utils/types/tsconfig.json
Expand Up @@ -6,11 +6,7 @@
"lib": ["es6", "dom"],
"module": "commonjs",
"noEmit": true,
"noImplicitAny": true,
"noImplicitThis": true,
"strict": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"target": "es5",
"typeRoots": ["../"],
"types": []
Expand Down
3 changes: 2 additions & 1 deletion packages/weak-memoize/package.json
Expand Up @@ -14,7 +14,8 @@
"access": "public"
},
"devDependencies": {
"dtslint": "^0.3.0"
"dtslint": "^4.2.1",
"typescript": "^4.5.5"
},
"files": [
"src",
Expand Down
4 changes: 0 additions & 4 deletions packages/weak-memoize/types/tsconfig.json
Expand Up @@ -5,11 +5,7 @@
"lib": ["es6", "dom"],
"module": "commonjs",
"noEmit": true,
"noImplicitAny": true,
"noImplicitThis": true,
"strict": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"target": "es5",
"typeRoots": ["../"],
"types": []
Expand Down
1 change: 1 addition & 0 deletions playgrounds/cra/package.json
Expand Up @@ -12,6 +12,7 @@
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test",
"test:typescript": "exit 0",
srmagura marked this conversation as resolved.
Show resolved Hide resolved
"eject": "react-scripts eject"
},
"browserslist": {
Expand Down
1 change: 1 addition & 0 deletions playgrounds/nextjs/package.json
Expand Up @@ -5,6 +5,7 @@
"scripts": {
"dev": "next dev -p 4000",
"build": "next build",
"test:typescript": "exit 0",
"start": "next start"
},
"dependencies": {
Expand Down