Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getLabelFromStackTrace edge case in Firefox #2615

Merged
merged 2 commits into from Jan 11, 2022

Conversation

srmagura
Copy link
Member

What:

Closes #2614.

Why:

Invalid class names were causing styles to not be applied.

How:

Add new tests and make them pass.

Checklist:

  • Documentation N/A
  • Tests
  • Code complete
  • Changeset

@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2022

🦋 Changeset detected

Latest commit: abd7ad8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 10, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit abd7ad8:

Sandbox Source
Emotion Configuration

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #2615 (be6a62d) into main (242f7d8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head be6a62d differs from pull request most recent head abd7ad8. Consider uploading reports for the commit abd7ad8 to get more accurate results
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/react/src/get-label-from-stack-trace.js | 100.00% <100.00%> (ø) | |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illegal classname generation in Firefox
2 participants