Prepare first RC release #2030
Merged
Prepare first RC release #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3bd9bc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
commented
Oct 3, 2020
| function getPreVersion(version) { | ||
| let parsed = semver.parse(version); | ||
| - let preVersion = parsed.prerelease[1] === undefined ? -1 : parsed.prerelease[1]; | ||
| + let preVersion = -1; |
There was a problem hiding this comment.
yes, i know it's excessive, but couldnt help myself 🤷♂️
There was a problem hiding this comment.
I've confirmed that it works locally OK. We'll review exact published versions when bot prepares a versioning PR
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3bd9bc0:
|
emmatown
approved these changes
Oct 3, 2020
Merged
|
@Andarist thanks for the steady work ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.