Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "on" amp html property to whitelist #1584

Merged
merged 3 commits into from Oct 29, 2019
Merged

add "on" amp html property to whitelist #1584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
543a3a5
add "on" amp html property to whitelist
quantizor Oct 28, 2019
5bb503b
add changeset
quantizor Oct 28, 2019
6bba96e
Merge branch 'master' into patch-1
emmatown Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/curvy-mangos-clap.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
'@emotion/is-prop-valid': patch
---

add "on" amp html attribute to the whitelist
2 changes: 2 additions & 0 deletions packages/is-prop-valid/src/props.js
View file
Open in desktop
Expand Up @@ -193,6 +193,8 @@ const props = {
// https://html.spec.whatwg.org/multipage/microdata.html#microdata-dom-api
itemID: true,
itemRef: true,
// used in amp html for eventing purposes
on: true,
// results show looking glass icon and recent searches on input
// search fields in WebKit/Blink
results: true,
Expand Down