New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade babel-plugin-emotion's touch
dependency to ^2.0.1
#861
Comments
mtzhang
changed the title
Upgrade babel-plugin-emotion's
Upgrade babel-plugin-emotion's Sep 19, 2018
touch
dependency to ^2.0.0touch
dependency to ^2.0.1
Would you like to create a PR for this? |
3 tasks
Thanks for @mitchellhamilton for merging the submitted PR! Is it possible to cut a patch release with this upgrade soon? Can I get an ETA on that? /cc @Andarist |
Fixed by #866 |
@mitchellhamilton Amazing, thank you so much! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
emotion
version: 9.1.2react
version: 16.2.0Relevant code.
emotion/packages/babel-plugin-emotion/package.json
Line 24 in d882e8b
emotion/packages/babel-plugin-emotion/src/index.js
Line 6 in d882e8b
emotion/packages/babel-plugin-emotion/src/index.js
Line 580 in d882e8b
What you did:
Within my project makefile
What happened / Problem description:
I'm using
react-select
in a project, which in turn is usingemotion
. I'm running into a problem with builds because ofemotion
's outdated dependency (specifically withinbabel-package-emotion
) ontouch
.During my project build, the $PATH variable is prepended with
node_modules/.bin
, so local executables can be conveniently used in the Makefile. Because it's prepended, thetouch
dependency takes precedence over the system touch, and because the older version of this library doesn't work with directories, builds are failing.Suggested solution:
Changing the $PATH to append node_modules/.bin to $PATH, as opposed to prepending it, is not a solution for my project, and so my suggested solution is to
update the touch dependency to at least v2.0.1.
This is because the name of the CLI installed by the package was changed from
touch.js
tonodetouch.js
in v2.0.0 (commit), with a small correction to the bin file name in v2.0.1 (commit). This will eliminate the problem of the same-named dependency.For additional context, a similar request to upgrade
touch
was made tonodemon
in July 2017 – see the following issue: remy/nodemon#1072.The text was updated successfully, but these errors were encountered: