Upgrade babel-plugin-emotion to 9.2.10 #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉thanks for this @mtzhang merged |
|
@gwyneplaine thanks! would be great to get a new release with these changes, whenever convenient 🙏 |
This was referenced Oct 24, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
babel-plugin-emotionto9.2.10, which includes an upgrade totouchthat resolves a name clash with the system touch. This was causing build errors when trying totoucha directory, which was not fixed until a later major version (diff fortouch@1.0.0...touch@2.0.1). Full detail in this issue emotion-js/emotion#861.Existing tests all still pass, and
yarn build,flow,test,lintall run without errors. Please let me know if I need to add additional documentation for this upgrade. I didn't open an issue because it would include much of the same information as this PR, as well as the linked issue in the emotion repo.See babel-plugin-emotion history for changes between v9.1.2, published April 17, 2018 and v9.2.10, published Sep 19, 2018.