Upgrade dtslint (#2653)

* Upgrade dtslint * Fix dtslint errors
emotion-js · Feb 19, 2022 · ce9873f · ce9873f
1 parent 29c99a9
commit ce9873f
Show file tree

Hide file tree

Showing 33 changed files with 246 additions and 175 deletions.
diff --git a/package.json b/package.json
@@ -213,7 +213,7 @@
     "bundlesize": "^0.13.2",
     "codecov": "^2.3.1",
     "cssjanus": "^1.2.0",
-    "dtslint": "^0.3.0",
+    "dtslint": "^4.2.1",
     "enzyme": "^3.11.0",
     "enzyme-adapter-react-16": "^1.15.5",
     "enzyme-to-json": "^3.6.1",

diff --git a/packages/cache/package.json b/packages/cache/package.json
@@ -23,7 +23,8 @@
   },
   "devDependencies": {
     "@emotion/hash": "*",
-    "dtslint": "^0.3.0"
+    "dtslint": "^4.2.1",
+    "typescript": "^4.5.5"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/cache/types/tsconfig.json b/packages/cache/types/tsconfig.json
@@ -6,11 +6,7 @@
     "lib": ["es6", "dom"],
     "module": "commonjs",
     "noEmit": true,
-    "noImplicitAny": true,
-    "noImplicitThis": true,
     "strict": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
     "target": "es5",
     "typeRoots": ["../"],
     "types": []

diff --git a/packages/css/package.json b/packages/css/package.json
@@ -34,7 +34,8 @@
   },
   "devDependencies": {
     "@babel/core": "^7.13.10",
-    "dtslint": "^0.3.0"
+    "dtslint": "^4.2.1",
+    "typescript": "^4.5.5"
   },
   "author": "Kye Hohenberger",
   "homepage": "https://emotion.sh",

diff --git a/packages/css/types/tsconfig.json b/packages/css/types/tsconfig.json
@@ -6,11 +6,7 @@
     "lib": ["es6", "dom"],
     "module": "commonjs",
     "noEmit": true,
-    "noImplicitAny": true,
-    "noImplicitThis": true,
     "strict": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
     "target": "es5",
     "typeRoots": ["../"],
     "types": []

diff --git a/packages/hash/package.json b/packages/hash/package.json
@@ -19,7 +19,8 @@
     "test:typescript": "dtslint types"
   },
   "devDependencies": {
-    "dtslint": "^0.3.0"
+    "dtslint": "^4.2.1",
+    "typescript": "^4.5.5"
   },
   "browser": {
     "./dist/emotion-hash.cjs.js": "./dist/emotion-hash.browser.cjs.js",

diff --git a/packages/hash/types/tsconfig.json b/packages/hash/types/tsconfig.json
@@ -5,11 +5,7 @@
     "lib": ["es6", "dom"],
     "module": "commonjs",
     "noEmit": true,
-    "noImplicitAny": true,
-    "noImplicitThis": true,
     "strict": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
     "target": "es5",
     "typeRoots": ["../"],
     "types": []

diff --git a/packages/is-prop-valid/package.json b/packages/is-prop-valid/package.json
@@ -17,7 +17,8 @@
     "@emotion/memoize": "^0.7.4"
   },
   "devDependencies": {
-    "dtslint": "^0.3.0"
+    "dtslint": "^4.2.1",
+    "typescript": "^4.5.5"
   },
   "files": [
     "src",

diff --git a/packages/is-prop-valid/types/tsconfig.json b/packages/is-prop-valid/types/tsconfig.json
@@ -5,11 +5,7 @@
     "lib": ["es6", "dom"],
     "module": "commonjs",
     "noEmit": true,
-    "noImplicitAny": true,
-    "noImplicitThis": true,
     "strict": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
     "target": "es5",
     "typeRoots": ["../"],
     "types": []

diff --git a/packages/jest/package.json b/packages/jest/package.json
@@ -39,13 +39,14 @@
     "@emotion/css": "11.7.1",
     "@emotion/react": "11.8.1",
     "@types/jest": "^27.0.3",
-    "dtslint": "^0.3.0",
+    "dtslint": "^4.2.1",
     "enzyme-to-json": "^3.6.1",
     "preact": "^8.2.9",
     "preact-render-to-json": "^3.6.6",
     "pretty-format": "^22.4.3",
     "react": "16.14.0",
-    "react-dom": "16.14.0"
+    "react-dom": "16.14.0",
+    "typescript": "^4.5.5"
   },
   "author": "Kye Hohenberger",
   "homepage": "https://emotion.sh",

diff --git a/packages/jest/types/tsconfig.json b/packages/jest/types/tsconfig.json
@@ -6,11 +6,7 @@
     "lib": ["es6", "dom"],
     "module": "commonjs",
     "noEmit": true,
-    "noImplicitAny": true,
-    "noImplicitThis": true,
     "strict": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
     "target": "es5",
     "types": []
   },

diff --git a/packages/memoize/package.json b/packages/memoize/package.json
@@ -14,7 +14,8 @@
     "access": "public"
   },
   "devDependencies": {
-    "dtslint": "^0.3.0"
+    "dtslint": "^4.2.1",
+    "typescript": "^4.5.5"
   },
   "files": [
     "src",

diff --git a/packages/memoize/types/tsconfig.json b/packages/memoize/types/tsconfig.json
@@ -5,11 +5,7 @@
     "lib": ["es6", "dom"],
     "module": "commonjs",
     "noEmit": true,
-    "noImplicitAny": true,
-    "noImplicitThis": true,
     "strict": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
     "target": "es5",
     "typeRoots": ["../"],
     "types": []

diff --git a/packages/native/package.json b/packages/native/package.json
@@ -17,9 +17,10 @@
   "devDependencies": {
     "@babel/core": "^7.13.10",
     "@types/react-native": "^0.63.2",
-    "dtslint": "^0.3.0",
+    "dtslint": "^4.2.1",
     "react": "16.14.0",
-    "react-native": "^0.63.2"
+    "react-native": "^0.63.2",
+    "typescript": "^4.5.5"
   },
   "dependencies": {
     "@emotion/primitives-core": "^11.0.0"

diff --git a/packages/native/types/tests.tsx b/packages/native/types/tests.tsx
@@ -23,9 +23,9 @@ declare module '@emotion/react' {
 const cssObject = {
   height: 100,
   width: '100%',
-  display: 'flex',
+  display: 'flex' as const,
   position: undefined
-} as const
+}
 
 const className = css`
   ${(true as boolean) && ''}

diff --git a/packages/native/types/tsconfig.json b/packages/native/types/tsconfig.json
@@ -6,14 +6,11 @@
     "lib": ["es6", "dom"],
     "module": "commonjs",
     "noEmit": true,
-    "noImplicitAny": true,
-    "noImplicitThis": true,
     "strict": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
     "target": "es5",
     "typeRoots": ["../"],
-    "types": []
+    "types": [],
+    "skipLibCheck": true
   },
   "include": ["./*.ts", "./*.tsx"]
 }
diff --git a/packages/react/package.json b/packages/react/package.json
@@ -54,10 +54,11 @@
     "@emotion/server": "11.4.0",
     "@emotion/styled": "11.8.1",
     "@types/react": "^16.9.11",
-    "dtslint": "^0.3.0",
+    "dtslint": "^4.2.1",
     "html-tag-names": "^1.1.2",
     "react": "16.14.0",
-    "svg-tag-names": "^1.1.1"
+    "svg-tag-names": "^1.1.1",
+    "typescript": "^4.5.5"
   },
   "repository": "https://github.com/emotion-js/emotion/tree/main/packages/react",
   "publishConfig": {

diff --git a/packages/react/types/tsconfig.json b/packages/react/types/tsconfig.json
@@ -6,11 +6,7 @@
     "lib": ["es6", "dom"],
     "module": "commonjs",
     "noEmit": true,
-    "noImplicitAny": true,
-    "noImplicitThis": true,
     "strict": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
     "target": "es5",
     "typeRoots": ["../"],
     "types": []

diff --git a/packages/serialize/package.json b/packages/serialize/package.json
@@ -21,7 +21,8 @@
     "csstype": "^3.0.2"
   },
   "devDependencies": {
-    "dtslint": "^0.3.0"
+    "dtslint": "^4.2.1",
+    "typescript": "^4.5.5"
   },
   "files": [
     "src",

diff --git a/packages/serialize/types/tsconfig.json b/packages/serialize/types/tsconfig.json
@@ -6,11 +6,7 @@
     "lib": ["es6", "dom"],
     "module": "commonjs",
     "noEmit": true,
-    "noImplicitAny": true,
-    "noImplicitThis": true,
     "strict": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
     "target": "es5",
     "typeRoots": ["../"],
     "types": []

diff --git a/packages/server/package.json b/packages/server/package.json
@@ -32,7 +32,8 @@
     "@emotion/css": "11.7.1",
     "@emotion/css-prettifier": "1.0.1",
     "@types/node": "^10.11.4",
-    "dtslint": "^0.3.0"
+    "dtslint": "^4.2.1",
+    "typescript": "^4.5.5"
   },
   "author": "Kye Hohenberger",
   "homepage": "https://emotion.sh",

diff --git a/packages/server/types/tsconfig.json b/packages/server/types/tsconfig.json
@@ -6,14 +6,11 @@
     "lib": ["es6"],
     "module": "commonjs",
     "noEmit": true,
-    "noImplicitAny": true,
-    "noImplicitThis": true,
     "strict": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
     "target": "es5",
     "typeRoots": ["../"],
-    "types": []
+    "types": [],
+    "skipLibCheck": true
   },
   "include": ["./*.ts", "./*.tsx"]
 }
diff --git a/packages/sheet/package.json b/packages/sheet/package.json
@@ -23,6 +23,7 @@
     "types/*.d.ts"
   ],
   "devDependencies": {
-    "dtslint": "^0.3.0"
+    "dtslint": "^4.2.1",
+    "typescript": "^4.5.5"
   }
 }
diff --git a/packages/sheet/types/tsconfig.json b/packages/sheet/types/tsconfig.json
@@ -6,11 +6,7 @@
     "lib": ["es6", "dom"],
     "module": "commonjs",
     "noEmit": true,
-    "noImplicitAny": true,
-    "noImplicitThis": true,
     "strict": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
     "target": "es5",
     "typeRoots": ["../"],
     "types": []

diff --git a/packages/styled/package.json b/packages/styled/package.json
@@ -33,8 +33,9 @@
   "devDependencies": {
     "@babel/core": "^7.13.10",
     "@emotion/react": "11.8.1",
-    "dtslint": "^0.3.0",
-    "react": "16.14.0"
+    "dtslint": "^4.2.1",
+    "react": "16.14.0",
+    "typescript": "^4.5.5"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/styled/types/tsconfig.json b/packages/styled/types/tsconfig.json
@@ -7,11 +7,7 @@
     "lib": ["es6", "dom"],
     "module": "commonjs",
     "noEmit": true,
-    "noImplicitAny": true,
-    "noImplicitThis": true,
     "strict": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
     "target": "es5",
     "typeRoots": ["../"],
     "types": []

diff --git a/packages/utils/package.json b/packages/utils/package.json
@@ -23,6 +23,7 @@
     "types/*.d.ts"
   ],
   "devDependencies": {
-    "dtslint": "^0.3.0"
+    "dtslint": "^4.2.1",
+    "typescript": "^4.5.5"
   }
 }
diff --git a/packages/utils/types/tsconfig.json b/packages/utils/types/tsconfig.json
@@ -6,11 +6,7 @@
     "lib": ["es6", "dom"],
     "module": "commonjs",
     "noEmit": true,
-    "noImplicitAny": true,
-    "noImplicitThis": true,
     "strict": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
     "target": "es5",
     "typeRoots": ["../"],
     "types": []

diff --git a/packages/weak-memoize/package.json b/packages/weak-memoize/package.json
@@ -14,7 +14,8 @@
     "access": "public"
   },
   "devDependencies": {
-    "dtslint": "^0.3.0"
+    "dtslint": "^4.2.1",
+    "typescript": "^4.5.5"
   },
   "files": [
     "src",

diff --git a/packages/weak-memoize/types/tsconfig.json b/packages/weak-memoize/types/tsconfig.json
@@ -5,11 +5,7 @@
     "lib": ["es6", "dom"],
     "module": "commonjs",
     "noEmit": true,
-    "noImplicitAny": true,
-    "noImplicitThis": true,
     "strict": true,
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
     "target": "es5",
     "typeRoots": ["../"],
     "types": []

diff --git a/playgrounds/cra/package.json b/playgrounds/cra/package.json
@@ -12,6 +12,7 @@
     "start": "react-scripts start",
     "build": "react-scripts build",
     "test": "react-scripts test",
+    "test:typescript": "exit 0",
     "eject": "react-scripts eject"
   },
   "browserslist": {

diff --git a/playgrounds/nextjs/package.json b/playgrounds/nextjs/package.json
@@ -5,6 +5,7 @@
   "scripts": {
     "dev": "next dev -p 4000",
     "build": "next build",
+    "test:typescript": "exit 0",
     "start": "next start"
   },
   "dependencies": {