Signed-off-by: Luke Shumaker <lukeshu@datawire.io>

Besides test retries being bad (they're there for the case that the test
intermittently flakes, but mask the case that the code-under-test only
intermittently works), this is important in order to remove the
`nick-invision/retry@v2.4.0` GitHub action.  It has a bug where if there
is too much output it marks the test as passing even if it fails.  That is
very bad, and we cannot permit that type of failure mode in our CI.

nick-fields/retry#76

Signed-off-by: Luke Shumaker <lukeshu@datawire.io>

fetcher.py's parse_watt() calls `watt_k8s.pop('annotations') or {}` to
pluck the annotations out of the watt snapshot.  Because the `pop`
call does not include a default this causes it to throw a KeyError
when `annotations` doesn't exist.  This isn't an issue in normal use,
as `pkg/snapshot/v1/types.go` doesn't say `,omitempty` on that field,
so it will always be present.  However this does cause a problem for
many of the unit tests, which don't set that field.  So, move the
default value to inside of the call to `pop`.

Signed-off-by: Lance Austin <laustin@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>

The test YAML parser doesn't need to be told about Namespaces; and indeed
it chokes on them because they don't have a `.metadata.namespace`.

Also, you can't multi-assign from a bool.

Signed-off-by: Luke Shumaker <lukeshu@datawire.io>

Remove the Python unit test for testing annotation parsing because it
is already being tested in `pkg/snapshot/v1/annotations_test.go`.

However, the Go version is missing tests for the following use cases:

- "getambassador.io/config" annotation is empty
- "getambassador.io/config" is empty missing

So add those 2 cases to the Go test.

Signed-off-by: Lance Austin <laustin@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>

Fixes: 417a831

Signed-off-by: Luke Shumaker <lukeshu@datawire.io>

Make it clear that "XXX" in this case means that something is wrong.

Signed-off-by: Luke Shumaker <lukeshu@datawire.io>