Switch to u64 from usize in many places #147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for such a long delay, work got in the way.
I've implemented the base changes needed to fix #141. Both diskstats and stat were changed to use
u64
. I've noticed my NAS having diskstat numbers in the tens of billions so I thought the change there was appropriate. Some places I'm still not sure what to do about:sys/vm
admin_reserve_kbytes
was kept as usize, as it would not make much sense to reserve billions of kilobytes.sys/fs
file_max
was kept as usize, since I am not sure where would billions of files be opened.However, both of these are rather arbitrary, and could be changed to u64. If you'd like that I'll be glad to make the change.
In the end, procfs now works just fine as a 32-bit executable on 64-bit machines.