Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for /proc/uptime #146

Merged
merged 1 commit into from Oct 4, 2021
Merged

Add support for /proc/uptime #146

merged 1 commit into from Oct 4, 2021

Conversation

oblique
Copy link
Contributor

@oblique oblique commented Sep 16, 2021

Support for /proc/uptime was missing.

@oblique
Copy link
Contributor Author

oblique commented Sep 30, 2021

@eminence ping

@eminence
Copy link
Owner

eminence commented Oct 2, 2021

Thanks for the ping (and thanks for the PR). This looks good to me, except for the typo causing the build error

@oblique oblique force-pushed the add-uptime branch 2 times, most recently from 3cc839b to 5afdbd0 Compare October 3, 2021 07:32
@oblique
Copy link
Contributor Author

oblique commented Oct 3, 2021

Oops! Fixed. I removed the _secs suffix. If you prefer it let me know and I will add it.

@oblique
Copy link
Contributor Author

oblique commented Oct 4, 2021

Fixed the test case issue for 1.34.0

@eminence
Copy link
Owner

eminence commented Oct 4, 2021

We are green. Thanks!

@eminence eminence merged commit 2230954 into eminence:master Oct 4, 2021
@eminence
Copy link
Owner

Hi @oblique, the latest v0.11.0 release contains this new feature. Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eminence eminence eminence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oblique @eminence