Z-ordering of shapes #2482
Closed
Z-ordering of shapes #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this! 🙏 I'm heading off to a long vacation, so it will be at least a month until I will get to reviewing this. Just a heads-up! |
emilk
requested changes
Jan 23, 2023
| for &(prev_id, prev_rect) in rects.iter().rev() { | ||
| if prev_id == id { | ||
| if let Some(rects) = slf.layer_rects_prev_frame.get_mut(&layer.area_layer) { | ||
| rects.sort_by_key(|(_id, z, ..)| *z); |
There was a problem hiding this comment.
re-sorting this on each interaction is unnecessary. Better to sort once at the end of each frame instead.
| painter.rect_filled(response.rect, Rounding::none(), Color32::BLUE); | ||
|
|
||
| if response.clicked() { | ||
| log::info!("Clicked blue"); |
There was a problem hiding this comment.
really nice that you test interaction too ⭐
Draft
|
Continued in #2633 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1516.
This PR implements the feature in the exact way described by @emilk. Library consumers are expected to set z-index using
ui.with_z(...).I've added an example to
examplesdemonstrating the feature.