add set_plot_bounds method, giving users the ability to set the plot bounds themselves. #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flxzt
changed the title
emilk
reviewed
Nov 22, 2022
emilk
approved these changes
Nov 22, 2022
emilk
added a commit
that referenced
this pull request
Dec 2, 2022
…bounds themselves. (#2320) * add set_plot_bounds method * call it from_min_max for consistency with Rect Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
JohannesProgrammiert
pushed a commit
to JohannesProgrammiert/egui
that referenced
this pull request
Jan 21, 2023
…bounds themselves. (emilk#2320) * add set_plot_bounds method * call it from_min_max for consistency with Rect Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the method
set_plot_bounds()to give users more control over the bounds of the plot. Some requested this in discussion #1328 . To use this, the user needs to be able to createPlotBoundsstructs so I added aPlotBounds::new()method as well.To give an example for usecases: implementing a digital oscilloscope or a serial plotter where you have fixed ranges controlled from other parts in or outside of the app.
This is sort of continuing #2145, which added the ability to translate the plot bounds by a delta.
I am not sure about adding this to the changelog? Let me know if I should add it, or if it is trivial and not worth mentioning.
Also: thank you for creating egui!