Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eframe: Don't follow system theme by default #1941

Merged
merged 1 commit into from Aug 20, 2022
Merged

Commits on Aug 20, 2022

  1. eframe: Don't follow system theme by default

    I have gone back and forth on this a bit, but I think the arguments
    AGAINST following the system theme are many:
    
    * `dark-light` is a big dependency with problems on Linux.
    * Many people prefer the dark mode and ask how to set it as the default
      (even though they are using light mode in their OS).
    * A developer may be surprised when the app changes theme when
      they run it on another computer.
    
    So, the path of least surprise is to make this an opt-in feature
    with dark mode as the default mode.
    
    On native, you add the `dark-light` feature to enable it.
    On web, you set `WebOptions::follow_system_theme`.
    emilk committed Aug 20, 2022
    Configuration menu
    Copy the full SHA
    46b0b76 View commit details
    Browse the repository at this point in the history