Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call scroll if TextEdit is fully in view #1779

Merged
merged 3 commits into from Jul 3, 2022
Merged

Don't call scroll if TextEdit is fully in view #1779

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
470683a
Don't call scroll if TextEdit is fully in view
Barugon Jun 30, 2022
2880fc2
Explain why the new logic was added
emilk Jul 3, 2022
d5ac563
cargo fmt
emilk Jul 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion egui/src/widgets/text_edit/builder.rs
View file
Open in desktop
Expand Up @@ -590,7 +590,9 @@ impl<'t> TextEdit<'t> {
&cursor_range.primary,
);

if response.changed || selection_changed {
if (response.changed || selection_changed)
&& !ui.clip_rect().contains_rect(rect)
{
emilk marked this conversation as resolved.
Show resolved Hide resolved
ui.scroll_to_rect(cursor_pos, None); // keep cursor in view
}

Expand Down