Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image button padding on hover #1595

Merged
merged 5 commits into from May 11, 2022
Merged

Conversation

newcomb-luke
Copy link
Contributor

This PR addresses one issue that has been encountered by multiple people where image buttons don't display correctly when hovering. This updates 2 lines of code that fix the problem as shown in the image below.

There are no clippy warnings.

./sh/check.sh was not able to be completed for some unrelated error below in speech-dispatcher:

error[E0308]: mismatched types
  --> /home/luke/.cargo/registry/src/github.com-1ecc6299db9ec823/speech-dispatcher-0.12.0/src/lib.rs:35:13
   |
35 |     Male1 = SPDVoiceType::SPD_MALE1,
   |             ^^^^^^^^^^^^^^^^^^^^^^^ expected `u32`, found `i32`

The fixed image buttons shown:

fixed_egui

Closes #1528.

@newcomb-luke newcomb-luke marked this pull request as draft May 7, 2022 16:51
@newcomb-luke newcomb-luke marked this pull request as ready for review May 7, 2022 16:52
@newcomb-luke newcomb-luke changed the title Draft: Fix image button padding on hover Fix image button padding on hover May 7, 2022
@emilk emilk merged commit e44c9b8 into emilk:master May 11, 2022
@emilk
Copy link
Owner

emilk commented May 11, 2022

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageButton's background doesn't take padding into account when selected/hovering
2 participants