Add example using three-d
#1398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/asny/three-d recently merged a PR adding `glow` support: asny/three-d#210 This means it is a prime candidate for embedding 3D painting inside an eframe app. There are currently a few kinks that need to be figured out: When reusing the same three_d context over time (as one should), we only get one frame of egui together with three_d, and then after that a black screen with just the three_d painting on top. I need to fix that before merging this PR. `Shape` is `Send + Sync` and `three_d::Context` is not. This means we cannot store a three_d context and send it to the `Shape::Callback`. So we either need to recreate the three_d context each frame (obviously a bad idea), or access it through a `thread_local` hack. This PR adds both as examples, with a checkbox to switch. We could consider making `Shape: !Send + !Sync`, but that would mean `egui::Context` could not be `Send+Sync` either (because the egui context stores shapes). This is discussed in #1399
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: rebased in #1407
https://github.com/asny/three-d recently merged a PR adding
glowsupport: asny/three-d#210.This means it is a prime candidate for embedding 3D painting inside an eframe app.
There are currently a few kinks that need to be figured out:
Send+SyncSudden egui paint failure
When reusing the same
three_dcontext over time (as one should), we get two(!) good frames ofegui+three_d, but frame three and onwards theeguipainting breaks (nothing is painted), but thethree_dstill works. Very weird!EDIT: fixed by asny/three-d@07bbf3b
Viewport
The
thee-dcamera requires a viewport (in pixels). This need to be passed in to thePaintCallbackfunction, or there needs to be some way of tellingthree-dto use the currently set viewport (less likely).EDIT: fixed by 9181dc7
Anti-aliasing
It would be nice to enable MSAA to smooth out the edges.
Shape: Send + SyncShapeisSend + Syncandthree_d::Contextis not. This means we cannot store a three_d context and send it to theShape::Callback.So we either need to recreate the three_d context each frame (obviously a bad idea), or access it through a
thread_localhack. This PR adds both as examples, with a checkbox to switch.We could consider making
Shape: !Send + !Sync, but that has a lot of downstream implications, as discussed in #1399