Per-corner rounding of rectangles #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not too sure of whether the changelog for this would go on either |
|
Whoops. Seems github does dont like renaming branches with open PRs |
emilk
requested changes
Feb 5, 2022
Comment on lines
+385
to
+388
| pub nw: f32, | ||
| pub ne: f32, | ||
| pub sw: f32, | ||
| pub se: f32, |
There was a problem hiding this comment.
Suggested change
| pub nw: f32, | |
| pub ne: f32, | |
| pub sw: f32, | |
| pub se: f32, | |
| /// north-west = left-top | |
| pub nw: f32, | |
| /// north-east = right-top | |
| pub ne: f32, | |
| /// south-west = left-bottom | |
| pub sw: f32, | |
| /// south-east = right-bottom | |
| pub se: f32, |
There was a problem hiding this comment.
Perhaps something like /// Top left (north-west) would be a bit better formatting wise for these?
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
emilk
changed the title
emilk
added a commit
that referenced
this pull request
Feb 5, 2022
Also update changelogs and clean up other aspects of #1206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever got bored of those plain old boring corners? Don't you feel they all look the same? Fear not, I have the solution for you:
Uses a new
Roundingstruct as discussed on the discord. Although maybe redundant, also gave it anewfunction to shorten things a bit when creating more complex layouts.I separated each corner into its own slider for what is shown in the demo app, however I have no idea where the other sliders inOh those are for widgets themselves. Seems the labels fit the style so that's good.WidgetVisualsgo to.Note: I was not able to run
check.shwhich seems to have already been reported here. Got a bunch ofmismatched typeerrors.