Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add on_hover_text_at_pointer #1179

Merged
merged 4 commits into from Feb 5, 2022
Merged

Add on_hover_text_at_pointer #1179

merged 4 commits into from Feb 5, 2022

Conversation

juancampa
Copy link
Contributor

@juancampa juancampa commented Jan 29, 2022 •
edited

Problem

Response::on_hover_ text ui
at_pointer missing ✅
not at_pointer ✅ ✅

I felt this function was missing so I added it

Solution

Add on_hover_text_at_pointer

@juancampa juancampa marked this pull request as ready for review January 29, 2022 20:46
emilk
emilk approved these changes Feb 2, 2022
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great justification image :)

@juancampa
Copy link
Contributor Author

This one is ready to merge ✔️

@emilk emilk merged commit 32a9b4a into emilk:master Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juancampa @emilk