eframe: Don't follow system theme by default #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have gone back and forth on this a bit, but I think the arguments AGAINST following the system theme are many: * `dark-light` is a big dependency with problems on Linux. * Many people prefer the dark mode and ask how to set it as the default (even though they are using light mode in their OS). * A developer may be surprised when the app changes theme when they run it on another computer. So, the path of least surprise is to make this an opt-in feature with dark mode as the default mode. On native, you add the `dark-light` feature to enable it. On web, you set `WebOptions::follow_system_theme`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have gone back and forth on this a bit, but I think the arguments
AGAINST following the system theme are many:
dark-lightis a big dependency with problems on Linux.(even though they are using light mode in their OS).
they run it on another computer.
So, the path of least surprise is to make this an opt-in feature
with dark mode as the default mode.
On native, you add the
dark-lightfeature to enable it.On web, you set
WebOptions::follow_system_theme.