Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry: update gunicorn to v21.2.0 #1436

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

jayaddison
Copy link
Contributor

Based on the gunicorn security support policy, I think we should update to the most-recent version v21.2.0 - it has been the latest version since its release on 2023-07-19, and seems relatively stable based on searching issues that mention it.

There is one bugreport benoitc/gunicorn#3038 - a possible regression since the v21.0.0 release series that isn't yet resolved.

Additionally there have been a few reports (ref, ref) of problems with eventlet (aka geventlet) - we don't use that worker-type though; we use gthread.

NB: The bugreport mentioned above does appear to be related to a gthread regression.

@jayaddison
Copy link
Contributor Author

There is one bugreport benoitc/gunicorn#3038 - a possible regression since the v21.0.0 release series that isn't yet resolved.

Update: I don't think we're affected by this because we don't configure --max-requests when running gunicorn.

@russss
Copy link
Member

russss commented Apr 16, 2024

I'll merge anyway to avoid any security warnings, thanks!

@russss russss merged commit ec367d1 into main Apr 16, 2024
3 checks passed
@russss russss deleted the maintenance/upgrade-gunicorn-v21.2.0 branch April 16, 2024 11:59
@jayaddison
Copy link
Contributor Author

Thanks - note that a fix for CVE-2024-1135 has been merged into gunicorn, but is pending a release (so dependabot alerts about that particular CVE won't be solved by this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants