Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped support for Python 2 #490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

claudep
Copy link

@claudep claudep commented Jul 28, 2020

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 90.061% when pulling 1633cc3 on claudep:droppy2 into 0badc75 on emcconville:master.

@claudep
Copy link
Author

claudep commented Jul 28, 2020

Note I didn't touch changelog.rst yet.

@emcconville
Copy link
Owner

Hey thanks for this body of work! I originally started thinking about dropping Python-2 for Wand-0.6.x, but got a lot of push back from legacy users. I think the current Python-2 users make up about 20% of Wand downloads.

@claudep
Copy link
Author

claudep commented Jul 28, 2020

Sure, you choose when the best moment is to drop Python 2. I took the risk to prepare the patch without asking first, so don't feel any pressure to push it now.
Once done, legacy users can still use wand as long as they pin it in their requirements (e.g. wand < 0.7.x).

@emcconville
Copy link
Owner

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants