Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge existing package.json to package created by embroider build #178

Merged

Conversation

dnalagatla
Copy link
Contributor

@ef4
Copy link
Contributor

ef4 commented May 17, 2019

Thanks, very nice work.

@ef4 ef4 merged commit 7b691c4 into embroider-build:master May 17, 2019
@ef4 ef4 mentioned this pull request Oct 21, 2019
@ef4
Copy link
Contributor

ef4 commented Oct 21, 2019

@dnalagatla this had to get reverted, see #342.

@st-h
Copy link

st-h commented Nov 2, 2019

@ef4 is there any other means to fix this or a work around? I am seeing the error described in #160, which was supposed to be fixed by this PR

@ef4
Copy link
Contributor

ef4 commented Nov 8, 2019

@st-h I reopened #160 to cover this.

We can still merge the package.json, but it needs to be implemented differently. This implementation was merging from the wrong spot in the build process.

@st-h
Copy link

st-h commented Nov 11, 2019

@ef4 thanks for the clarification. I am just trying to give embroider a spin every now and then to see if I can make it work with my app. But I can hold off, if it's still too early. Unfortunately that I can't dedicate more time to fix stuff right now.

@dnalagatla
Copy link
Contributor Author

@st-h I reopened #160 to cover this.

We can still merge the package.json, but it needs to be implemented differently. This implementation was merging from the wrong spot in the build process.

hi, @ef4 I am going to look into this issue. Can you please provide details regarding where the merging of package.json should happen. I can take a look into that.

@ef4
Copy link
Contributor

ef4 commented Feb 10, 2020

See #383 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants