Detect babel-plugin-ember-template-complation when other plugins are … #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preventing parallelization We need to detect and replace the template compilation plugin that is likely to be present in a v1 addon. We were missing one newish case: - ember-cli-htmlbars 6.0 - with an ember version that doesn't need the old modulesApiPolyfill - when some other babel plugin is preventing ember-cli-babel from parallelizing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…preventing parallelization
We need to detect and replace the template compilation plugin that is likely to be present in a v1 addon. We were missing one new-ish case:
The symptom when this fails is that templates get compiled to wire format too early, so we miss doing staticComponent (and helper and modifier) analysis, so you end up with missing components / helpers / modifiers in a v1 addon at runtime.
Fixes #1296