Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compat to check for both *.hbs & *.hbs.js #1295

Merged
merged 2 commits into from Nov 28, 2022
Merged

Update compat to check for both *.hbs & *.hbs.js #1295

merged 2 commits into from Nov 28, 2022

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Nov 28, 2022

This builds on #1294 by adding test coverage and by limiting the effect to only apply to the output of the compatibility stage1. We don't want apps to accidentally use this naming pattern.

kiosion and others added 2 commits November 26, 2022 16:53
SynthesizeTemplateOnlyComponents is used both for the app and the v1 addons. We only want the special .hbs.js compatibility behavior in v1 addons, not in the app.

This also adds test coverage.
@ef4 ef4 merged commit 3ef6696 into main Nov 28, 2022
@ef4 ef4 deleted the kiosion/main branch November 28, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants