Fix issue while saving gjs/gts where prettier deletes the contents of the file: Downgrade prettier-plugin-ember-template-tag until we're on prettier@v3 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Aug 17, 2023
|
|
||
| it('build and test ', async () => { | ||
| // Copy over fixtures | ||
| await helper.fixtures.use('./my-addon/src/components'); |
There was a problem hiding this comment.
re-copying over the fixtures here hid this problem from us in #159
NullVoxPopuli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary alternative to:
Still resolves:
Note that our tests currently don't catch this class of problem.
Only running
lint:fixwould catch this, and ember-cli doesn't run lint:fix after generating an addon: ember-cli/ember-cli#10334 (I need to come back to this)