Fix tests when deprecations are enabled #20695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kategengler
reviewed
May 9, 2024
| /resolved templates/, | ||
| DEPRECATIONS.DEPRECATE_COMPONENT_TEMPLATE_RESOLVING.isEnabled | ||
| ); | ||
| async [`@test template-only components`]() { |
There was a problem hiding this comment.
This is weird, no? What made you put that there in the first place?
There was a problem hiding this comment.
Probably a couple things:
- I originally was not updating these tests to use setComponenttemplate
- I changed (per Ed's suggestion) the timing of when the deprecation is thrown to only occur if there is a found resolved template, rather than anytime
layoutForis called (this ended up simplifying the implementation in resolver.ts)
packages/@ember/-internals/glimmer/tests/integration/components/component-template-test.js
Show resolved
Hide resolved
kategengler
merged commit 6f260cb
into
emberjs:kg-fix-run-with-deprecations-enabled
27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃