Deprecate import Ember from 'ember'
#20686
Open
+843
−785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Apr 22, 2024
There was a problem hiding this comment.
I'm surprised it didn't treat this file as a move...
There was a problem hiding this comment.
My trick for reliably getting git to understand a move: Make a commit with just the file rename and no other changes, even if it leaves the codebase in a broken state for that commit.
NullVoxPopuli
commented
Apr 22, 2024
| @@ -90,6 +90,15 @@ function deprecation(options: DeprecationOptions) { | |||
| test the behavior without encountering the deprecated feature, just as users would. | |||
| */ | |||
| export const DEPRECATIONS = { | |||
| DEPRECATE_IMPORT_EMBER(importName: string) { | |||
There was a problem hiding this comment.
this is and needs to be a function, I hope that's ok 😅
NullVoxPopuli
commented
Apr 22, 2024
| import * as templateCompilation from '@ember/template-compilation'; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-namespace | ||
| namespace Ember { |
There was a problem hiding this comment.
I have a hunch that some of these types may need to move back to the index.ts, but we'll see as the PR progresses
NullVoxPopuli
force-pushed
the
deprecate-import-ember-from-ember
branch
2 times, most recently
from
17a6f91
to
b5eaa95
Compare
NullVoxPopuli
force-pushed
the
deprecate-import-ember-from-ember
branch
from
7a95c95
to
70d0ca8
Compare
…ty is accessed, because we re-export the ember barrel from the template compiler
NullVoxPopuli
force-pushed
the
deprecate-import-ember-from-ember
branch
from
703a25b
to
3e46fe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: emberjs/rfcs#1003
Guide: ember-learn/deprecation-app#1381
Advancement: emberjs/rfcs#1015