Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RFC#995, Deprecate component template resolution #20660

Merged
merged 32 commits into from Apr 25, 2024
Merged

Implement RFC#995, Deprecate component template resolution #20660

merged 32 commits into from Apr 25, 2024

Commits on Apr 25, 2024

  1. Deprecate component template resolution 

    RFC: emberjs/rfcs#995
    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    880640f View commit details
    Browse the repository at this point in the history

  2. Re-work how components are built in the internal test helpers

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2ab758f View commit details
    Browse the repository at this point in the history

  3. Down to 52 failing tests

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d75d40b View commit details
    Browse the repository at this point in the history

  4. 40 left

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9bb9c1c View commit details
    Browse the repository at this point in the history

  5. Add checkbox to enable deprecations

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    85255bc View commit details
    Browse the repository at this point in the history

  6. 728 failing tests with the deprecations turned on

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4ac5332 View commit details
    Browse the repository at this point in the history

  7. Down to 13

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8314402 View commit details
    Browse the repository at this point in the history

  8. Base tests pass again after test harness updates

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    c7508cc View commit details
    Browse the repository at this point in the history

  9. Update the test-resolver-application

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f0b3ec3 View commit details
    Browse the repository at this point in the history

  10. Add attempted lookup in error message

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    53f346a View commit details
    Browse the repository at this point in the history

  11. Wip try to fix debug render tree tests

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2a9722e View commit details
    Browse the repository at this point in the history

  12. Update lookupComponent and lookupComponentPair to not try to resolve … 

    …templates once the deprecation is in the removed state
    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9453279 View commit details
    Browse the repository at this point in the history

  13. progress

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ae90597 View commit details
    Browse the repository at this point in the history

  14. Progress

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1cdf2d7 View commit details
    Browse the repository at this point in the history

  15. Progress

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    80a62a6 View commit details
    Browse the repository at this point in the history

  16. 4 tests left

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    3851dc2 View commit details
    Browse the repository at this point in the history

  17. lints

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    664bab0 View commit details
    Browse the repository at this point in the history

  18. Done?

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ea8d156 View commit details
    Browse the repository at this point in the history

  19. 'Fix' type errors

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    563ddc0 View commit details
    Browse the repository at this point in the history

  20. I think everything is green?

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    14eb06c View commit details
    Browse the repository at this point in the history

  21. Make smoke-tests pass again

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4f90a1a View commit details
    Browse the repository at this point in the history

  22. idk how to fix this

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    178e891 View commit details
    Browse the repository at this point in the history

  23. Yay

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    10f2d8c View commit details
    Browse the repository at this point in the history

  24. Remove code from curly manager that is no longer needed

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4985f91 View commit details
    Browse the repository at this point in the history

  25. Change from isRemoved() to .isRemoved

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    869b733 View commit details
    Browse the repository at this point in the history

  26. cleanup

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    5c11fd2 View commit details
    Browse the repository at this point in the history

  27. Move deprecation to be if layoutFor has a result only

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2fe2ec9 View commit details
    Browse the repository at this point in the history

  28. Add a non-deprecated version of the append lifecycle test

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    06268ce View commit details
    Browse the repository at this point in the history

  29. Re-fix upstream-changed test

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    79ede0e View commit details
    Browse the repository at this point in the history

  30. Move early nullification to layoutFor

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f17365f View commit details
    Browse the repository at this point in the history

  31. Remove unneeded branch

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    52978cd View commit details
    Browse the repository at this point in the history

  32. Fix qunit param

    @NullVoxPopuli
    NullVoxPopuli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    eb8fc81 View commit details
    Browse the repository at this point in the history