Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ember-cli-babel 8.2.0 #20557

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Sponsor Contributor

@NullVoxPopuli NullVoxPopuli commented Oct 14, 2023

ember-cli-babel 8 includes nice things for supporting content-tag.

Ideally, however, once ember-source is a v2 addon, we can just remove ember-cli-babel.

The breaking change from ember-cli-babel 7 to 8: https://github.com/emberjs/ember-cli-babel/releases/tag/v8.0.0

is that the consuming project must have declared @babel/core, which is already in the blueprint: https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/package.json#L29
(but was not added until ember-cli 5.3).

So, does this mean that ember-source can't upgrade ember-cli-babel?
and instead should convert to v2 addon? (I'm thinking it does).

However, this needs finished, but I don't know what's going on anymore.

@kategengler
Copy link
Member

Is this still relevant? It is a draft PR

@NullVoxPopuli
Copy link
Sponsor Contributor Author

oh probably, I should rebase

@kategengler
Copy link
Member

and convert from draft, if you want it merged :)

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like lints don't enforce sort order here -- leaving tooling to mess things up.....

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review December 12, 2023 20:06
@kategengler kategengler requested a review from ef4 December 12, 2023 20:15
@NullVoxPopuli
Copy link
Sponsor Contributor Author

@chancancode
Copy link
Member

Yeah, I am not sure what is the answer to your questions (basically: would it have been a breaking change if we required a new peer dependency?). I did write in my commit message that, if we couldn’t upgrade easily, I only needed the static block plugin so I could also configure that directly

@chancancode
Copy link
Member

But if we are going to do that, feel free to land it here and I’ll rebase when it’s available. I don’t necessarily think that other branch is intended for direct merging anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants