Skip to content

[BUGFIX beta] Provide a .d.ts file at types/stable #20194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Conversation

chriskrycho
Copy link
Contributor

@chriskrycho chriskrycho commented Sep 15, 2022

This file currently does nothing, but in the months ahead will look more and more like the /types/preview/index.d.ts while that one empties. This is just here so that someone who writes the import we recommend—

import 'ember-source';
import 'ember-source/preview';

—will not get warnings from TypeScript while we wait on putting actual things here!


Discovered this gap yesterday while prepping the preview types blog post! Note that it does not cause a compile error not to have this, but people will notice a warning in their editors.

Verified

This commit was signed with the committer’s verified signature.
chriskrycho Chris Krycho
This file currently does nothing, but in the months ahead will look more
and more like the `/types/preview/index.d.ts` while that one empties.
This is just here so that someone who writes the import we recommend--

```ts
import 'ember-source';
import 'ember-source/preview';
```

--will not get warnings from TypeScript while we wait on putting actual
things here!
@chriskrycho chriskrycho added Bug TypeScript Work on Ember’s types labels Sep 15, 2022
@chriskrycho chriskrycho merged commit cc874f6 into master Sep 15, 2022
@chriskrycho chriskrycho deleted the ts-stable-index branch September 15, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug TypeScript Work on Ember’s types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants