Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP beta] remove the --test-type option from the helper blueprint #19808

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Oct 30, 2021

This removes the --test-type option from the helper blueprint. The unit test blueprint has been broken for a while now, and it was suggested that this option should be removed since rendering tests are the recommended testing type for helpers.

Closes #18245

Rendering tests are the recommended test type for  helpers.
It seems the previous version of the blueprints produced some extra whitespace which can now be removed.
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!!

@rwjblue rwjblue merged commit e638f88 into emberjs:master Nov 4, 2021
@Windvis Windvis deleted the cleanup/remove-helper-blueprint-test-type-option branch November 4, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helper-test --test-type unit generates broken code in Ember 3.11
2 participants