[BUGFIX Release] fix router test regression for isActive #19789

NullVoxPopuli · 2021-10-14T13:40:30Z

draft PR for now, I need to verify on some internal code

Continuation of #19733

The recently modules API update means we are now loading real modules, not polyfills based on the global. This means that the modules themselves are _eagerly required_, rather than being references to a value on the global. For example, previously, this: ```js import { registerWaiter } from '@ember/test'; if (someCondition) { registerWaiter(() => {}); } ``` Would become this: ```js if (someCondition) { Ember.Test.registerWaiter(() => {}); } ``` In either example, `registerWaiter` may or may not be called based on the state of `someCondition`. However, in the second case, if `Ember.Test` is not defined at all, it's completely ok as long as `someCondition` is `false`. It's never called, so we never get an error telling us `Ember.Test` is undefined. Without the transform, the module is eagerly required, along with all of its dependencies. If no one included `ember-testing`, then that means it will throw an error immediately. This PR makes the `@ember/test` module load `ember-testing` lazily, and if it's not available (e.g. in a production environment) it replaces the values with a function that throws a helpful error.

@href

* Unify deprecation ids * Add missing `url` and `since` * Correctly reference `@ember/legacy-built-in-components` addon * Error instead for `<LinkTo @href=...>`

https://emberjs.com/deprecations/* is a redirect for https://deprecations.emberjs.com/*

(cherry picked from commit 8e57edd)

Makes the hash helper's individual keys lazy so that they do not eagerly incur costs. (cherry picked from commit 7d334cf)

Makes all {{hash}} object properties settable, but deprecates setting them. (cherry picked from commit ec4c034)

(cherry picked from commit e19e975)

(cherry picked from commit 692c3b8)

(cherry picked from commit c69365b)

(cherry picked from commit 844c2f4)

(cherry picked from commit e28a201)

Example message: ``` Usage of the Ember Global is deprecated. You should import the Ember module or the specific API instead. See https://deprecations.emberjs.com/v3.x/#toc_ember-global for details. Usages of the Ember Global may be caused by an outdated ember-cli-babel dependency. The following steps may help: * Upgrade your `devDependencies` on `ember-cli-babel` to `^7.26.6`. * Upgrade the following addons to the latest version: * active-model-adapter * ember-animated * ember-async-await-helper * ember-attacher * ember-cli-showdown * ember-freestyle * ember-md5 ### Important ### In order to avoid repeatedly showing the same deprecation messages, no further deprecation messages will be shown for usages of the Ember Global until ember-cli-babel is upgraded to v7.26.6 or above. To see all instances of this deprecation message at runtime, set the `EMBER_GLOBAL_DEPRECATIONS` environment variable to "all", e.g. `EMBER_GLOBAL_DEPRECATIONS=all ember test`. ### Details ### Prior to v7.26.6, ember-cli-babel sometimes transpiled imports into the equivalent Ember Global API, potentially triggering this deprecation message even when you did not directly reference the Ember Global. The following outdated versions are found in your project: * ember-cli-babel@6.11.0, currently used by: * ember-md5@6.11.0 * Depends on ember-cli-babel@6.11.0 * ember-cli-babel@6.18.0, currently used by: * active-model-adapter@6.18.0 * Depends on ember-cli-babel@^6.8.2 * ember-angle-bracket-invocation-polyfill@6.18.0 * Depends on ember-cli-babel@^6.17.0 * Added by ember-animated@0.11.0 * ember-async-await-helper@6.18.0 * Depends on ember-cli-babel@^6.16.0 * ember-cli-deploy-bugsnag@6.18.0 (Dormant) * Depends on ember-cli-babel@^6.16.0 * ember-cli-showdown@6.18.0 * Depends on ember-cli-babel@^6.8.1 * ember-inflector@6.18.0 * Depends on ember-cli-babel@^6.0.0 * Added by active-model-adapter@2.2.0 * ember-maybe-import-regenerator@6.18.0 (Dormant) * Depends on ember-cli-babel@^6.0.0-beta.4 * Added by ember-animated@0.11.0 * ember-named-arguments-polyfill@6.18.0 (Dormant) * Depends on ember-cli-babel@^6.6.0 * Added by ember-animated@0.11.0 * ember-raf-scheduler@6.18.0 * Depends on ember-cli-babel@^6.6.0 * Added by ember-attacher@1.2.3 > ember-popper@0.11.3 * ember-runtime-enumerable-includes-polyfill@6.18.0 (Dormant) * Depends on ember-cli-babel@^6.9.0 * Added by ember-freestyle@0.12.11 * ember-cli-babel@7.26.5, currently used by: * @embroider/macros@7.26.5 (Compatible) * Depends on ember-cli-babel@^7.23.0 * Added by ember-cli-mirage@2.2.0 * Added by ember-exam@6.1.0 * direwolf (your app) * Depends on ember-cli-babel@7.26.5 * ember-attacher@7.26.5 (Compatible) * Depends on ember-cli-babel@^7.23.0 * ember-fetch@7.26.5 (Compatible) * Depends on ember-cli-babel@^7.23.0 * ember-freestyle@7.26.5 (Compatible) * Depends on ember-cli-babel@^7.23.0 * ember-inflector@7.26.5 (Compatible) * Depends on ember-cli-babel@^7.23.0 * Added by ember-data@3.26.0 * Added by ember-cli-mirage@2.2.0 * ember-source@7.26.5 (Dormant) * Depends on ember-cli-babel@^7.23.0 * qunit-dom@7.26.5 (Dormant) * Depends on ember-cli-babel@^7.23.0 Note: Addons marked as "Dormant" does not appear to have any JavaScript files. Therefore, even if they are using an old version ember-cli-babel, they are unlikely to be the cuplrit of this deprecation and can likely be ignored. Note: Addons marked as "Compatible" are already compatible with ember-cli-babel@7.26.6. Try upgrading your `devDependencies` on `ember-cli-babel` to `^7.26.6`. ``` (cherry picked from commit bb9d96e)

Show details about outdated ember-cli-babel and only show the first instance by default. Example message: ``` Using `computed.reads` has been deprecated. Instead, import the value directly from @ember/object/computed: import { reads } from '@ember/object/computed'; These usages may be caused by an outdated ember-cli-babel dependency. The following steps may help: * Upgrade the following addons to the latest version: * active-model-adapter * ember-animated * ember-async-await-helper * ember-attacher * ember-cli-showdown * ember-md5 ### Important ### In order to avoid repeatedly showing the same deprecation messages, no further deprecation messages will be shown for theses deprecated usages until ember-cli-babel is upgraded to v7.26.6 or above. To see all instances of this deprecation message, set the `EMBER_RUNLOOP_AND_COMPUTED_DOT_ACCESS_DEPRECATIONS` environment variable to "all", e.g. `EMBER_RUNLOOP_AND_COMPUTED_DOT_ACCESS_DEPRECATIONS=all ember test`. ### Details ### Prior to v7.26.6, ember-cli-babel sometimes transpiled imports into the equivalent Ember Global API, potentially triggering this deprecation message indirectly, even when you did not observe these deprecated usages in your code. The following outdated versions are found in your project: * ember-cli-babel@6.11.0, currently used by: * ember-md5@6.11.0 * Depends on ember-cli-babel@6.11.0 * ember-cli-babel@6.18.0, currently used by: * active-model-adapter@6.18.0 * Depends on ember-cli-babel@^6.8.2 * ember-angle-bracket-invocation-polyfill@6.18.0 * Depends on ember-cli-babel@^6.17.0 * Added by ember-animated@0.11.0 * ember-async-await-helper@6.18.0 * Depends on ember-cli-babel@^6.16.0 * ember-cli-deploy-bugsnag@6.18.0 (Dormant) * Depends on ember-cli-babel@^6.16.0 * ember-cli-showdown@6.18.0 * Depends on ember-cli-babel@^6.8.1 * ember-inflector@6.18.0 * Depends on ember-cli-babel@^6.0.0 * Added by active-model-adapter@2.2.0 * ember-maybe-import-regenerator@6.18.0 (Dormant) * Depends on ember-cli-babel@^6.0.0-beta.4 * Added by ember-animated@0.11.0 * ember-named-arguments-polyfill@6.18.0 (Dormant) * Depends on ember-cli-babel@^6.6.0 * Added by ember-animated@0.11.0 * ember-raf-scheduler@6.18.0 * Depends on ember-cli-babel@^6.6.0 * Added by ember-attacher@1.2.3 > ember-popper@0.11.3 * ember-runtime-enumerable-includes-polyfill@6.18.0 (Dormant) * Depends on ember-cli-babel@^6.9.0 * Added by ember-freestyle@0.12.11 Note: Addons marked as "Dormant" does not appear to have any JavaScript files. Therefore, even if they are using an old version ember-cli-babel, they are unlikely to be the cuplrit of this deprecation and can likely be ignored. ``` (cherry picked from commit 7a8ab95)

(cherry picked from commit 72c3fd7)

(cherry picked from commit 1d49ea9)

(cherry picked from commit 6706b17)

Ensures that computeds can depend on dynamic hash keys that did not exist on the original hash. (cherry picked from commit 628a928)

(cherry picked from commit 926452f)

Fixes a few things: * Ensures that Embroider has a consistent protocol for ensuring the global is bootstrapped * Allows our override code to be transpiled * Ensures that any bootstrapping tweaks force us out of "prebuilt" mode (allowing that customized bootstrap code to actually run) Refactors the work in emberjs#19557 to address some of the recent comments there. (cherry picked from commit 5ad6f79)

As part of the improvements made between 3.24 and 3.28, the router microlib is now lazily loaded. When these changes were made, there were a couple cases where it *should* be possible to access router state in a non-application test (integration etc.) but it currently is not because the router is not necessarily set up. Since `setupRouter` is idempotent, call it in those functions so that if it is *not* set up, it gets set up, and otherwise it will continue working as expected. (cherry picked from commit 9f61c7a)

See glimmerjs/glimmer-vm#1351 for context.

rwjblue

I think we need a bit more info here, and likely a failing test case that emulates your scenario.

NullVoxPopuli · 2021-10-22T12:41:28Z

Yeah, I haven't actually had a chance to confirm if this works, because in my app I'm getting this error:

Compile Error: <:default> is not a component and doesn't support block parameters

it points at a file doing:

<SomeComponent>
  <:default>
    {{!-- ... --}}

But I haven't yet been able to reproduce :(
(not that I've been able to put a lot of energy into getting to the bottom of it*)

NullVoxPopuli · 2021-10-22T12:48:14Z

Well, rebasing to the latest 3.28 got me passed that. (3.28.2)

@rwjblue, I'll add a test as soon as I can confirm that this is worth finishing

(cherry picked from commit 6707ad3)

NullVoxPopuli · 2021-10-22T12:52:16Z

My current error is

Build Error (broccoli-persistent-filter:Babel > [Babel: @ember/test-helpers]) in @ember/test-helpers/setup-rendering-context.js

<my-app>/@ember/test-helpers/setup-rendering-context.js: Cannot read property 'indexOf' of null

I know this is unrelated, but I think it important to document this stuff, and I don't know where else atm.

Fixes emberjs#19797. (cherry picked from commit d9a83a4)

See https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.80.3

NullVoxPopuli · 2021-10-22T18:07:52Z

nay, this does not fix my issue, even after rebasing on top of 3.28.4 hmm

NullVoxPopuli · 2021-10-22T18:33:18Z

Well, this seems unrelated as I'm still getting:

  TypeError: Cannot set properties of null (setting 'localName')
                at Object.<anonymous> (https://localhost:60050/search/assets/tests.js:2295:49)

when trying to access the currentRoute on the router service

NullVoxPopuli · 2021-10-22T18:34:13Z

oh no, they've stubbed the router...

properties

NullVoxPopuli · 2021-10-22T19:54:47Z

I was gonna close this for now, because I seem to not need it now that I removed the code that was stubbing the router 🙃

But, I was thinking that if the router is ever not setup, wouldn't it be better to set it up in the _router getter?

I've pushed up an example.
This way all accessed properties setup the router lazily.

NullVoxPopuli · 2021-10-22T19:55:32Z

packages/@ember/-internals/routing/lib/services/router.ts

@@ -511,7 +509,9 @@ RouterService.reopen(Evented, {
     @type String
     @public
   */
-  currentRouteName: readOnly('_router.currentRouteName'),
+  get currentRouteName() {


this is an unrelated change -- I can revert this if the approach currently committed is desired (while I add tests)

NullVoxPopuli · 2022-01-29T23:03:05Z

Gonna close this for now -- it's been too long and I don't remember what was going on -- will submit a new PR if I encounter this again when I go back to trying some 3.25 -> 3.28 upgrades

kategengler and others added 30 commits May 3, 2021 11:56

Disable non-enabled feature

666ae33

Add v3.28.0-beta.1 to CHANGELOG

916e104

Release v3.28.0-beta.1

68fccf9

[BUGFIX release] 3.27 deprecation metadata

713a4c2

* Unify deprecation ids * Add missing `url` and `since` * Correctly reference `@ember/legacy-built-in-components` addon * Error instead for `<LinkTo @href=...>`

[CLEANUP] Deprecations URL consistency

d79f94f

https://emberjs.com/deprecations/* is a redirect for https://deprecations.emberjs.com/*

Release notes for v3.27.1

b3b4e53

(cherry picked from commit 8e57edd)

[BUGFIX] Makes the (hash) helper lazy

87b43a1

Makes the hash helper's individual keys lazy so that they do not eagerly incur costs. (cherry picked from commit 7d334cf)

[BUGFIX release] Make {{hash}} object properties settables

e50dc6e

Makes all {{hash}} object properties settable, but deprecates setting them. (cherry picked from commit ec4c034)

[DOC release] fix passing params to named blocks examples

6eb573c

(cherry picked from commit e19e975)

fix computed deprecation import path

3b1d38c

(cherry picked from commit 692c3b8)

[BUGFIX] pass module prefix to initializer test blueprints

01608b7

(cherry picked from commit c69365b)

Use explicit this in helper-test blueprints

65a75d0

(cherry picked from commit 844c2f4)

[BUGFIX release] Improve class based tranform deprecation message

ec0c86e

(cherry picked from commit e28a201)

Downlevel for IE11

d9a66ae

(cherry picked from commit 72c3fd7)

fix: lookup/register and singleton flag behavior

c54ed9e

(cherry picked from commit 1d49ea9)

fix lint

02b4e2e

(cherry picked from commit 6706b17)

Add v3.27.2 to CHANGELOG.md.

df6636a

Add v3.28.0-beta.2 to CHANGELOG.md.

c203d79

3.28.0-beta.2

5f368b0

[BUGFIX lts] Ensures that computed can depend on dynamic hash keys

a4099ea

Ensures that computeds can depend on dynamic hash keys that did not exist on the original hash. (cherry picked from commit 628a928)

Extend transition deprecation

a10b4bc

(cherry picked from commit 926452f)

Add v3.28.0-beta.3 to CHANGELOG

055b923

Release v3.28.0-beta.3

20b4eff

Add v3.27.3 to CHANGELOG.md.

edbfc03

Add v3.28.0-beta.4 to CHANGELOG

e31720c

Release v3.28.0-beta.4

2f54b0b

chriskrycho and others added 2 commits August 30, 2021 16:37

Add v3.28.1 to CHANGELOG.md.

c37df4d

NullVoxPopuli changed the base branch from master to release October 14, 2021 13:40

NullVoxPopuli force-pushed the more-router-setup-fixes branch from acfd420 to 13eba5c Compare October 14, 2021 13:41

NullVoxPopuli changed the title ~~[BUGFIX LTS] fix router test regression for isActive~~ [BUGFIX Release] fix router test regression for isActive Oct 14, 2021

rwjblue added 3 commits October 21, 2021 19:02

Update glimmer-vm to allow locals in loose mode

5f4ccf9

See glimmerjs/glimmer-vm#1351 for context.

Add v3.28.2 to CHANGELOG.md.

4c0e61b

3.28.2

5fc912b

rwjblue reviewed Oct 22, 2021

View reviewed changes

rwjblue added 3 commits October 22, 2021 08:49

Update glimmer-vm to 0.80.2 (fix some inline precompile issues)

eb40ee3

(cherry picked from commit 6707ad3)

Add v3.28.3 to CHANGELOG.md.

845e827

3.28.3

6932490

ef4 and others added 4 commits October 22, 2021 12:27

Don't pass falsy locals to glimmer precompile

1402cb4

Fixes emberjs#19797. (cherry picked from commit d9a83a4)

Update glimmer-vm to 0.80.3

f41c849

See https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.80.3

Add v3.28.4 to CHANGELOG.md.

d5e3540

3.28.4

62976fe

[BUGFIX LTS] fix router test regression for all router service

739b62a

properties

NullVoxPopuli force-pushed the more-router-setup-fixes branch from 13eba5c to 739b62a Compare October 22, 2021 19:54

NullVoxPopuli commented Oct 22, 2021

View reviewed changes

kategengler force-pushed the release branch from 5ec85ec to 6efc59c Compare November 15, 2021 23:23

kategengler force-pushed the release branch from cf1f34e to b81e324 Compare December 28, 2021 21:51

NullVoxPopuli closed this Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUGFIX Release] fix router test regression for isActive #19789

[BUGFIX Release] fix router test regression for isActive #19789

NullVoxPopuli commented Oct 14, 2021 •

edited

rwjblue left a comment

NullVoxPopuli commented Oct 22, 2021 •

edited

NullVoxPopuli commented Oct 22, 2021 •

edited

NullVoxPopuli commented Oct 22, 2021 •

edited

NullVoxPopuli commented Oct 22, 2021

NullVoxPopuli commented Oct 22, 2021

NullVoxPopuli commented Oct 22, 2021

NullVoxPopuli commented Oct 22, 2021

NullVoxPopuli Oct 22, 2021

NullVoxPopuli commented Jan 29, 2022

[BUGFIX Release] fix router test regression for isActive #19789

[BUGFIX Release] fix router test regression for isActive #19789

Conversation

NullVoxPopuli commented Oct 14, 2021 • edited

rwjblue left a comment

Choose a reason for hiding this comment

NullVoxPopuli commented Oct 22, 2021 • edited

NullVoxPopuli commented Oct 22, 2021 • edited

NullVoxPopuli commented Oct 22, 2021 • edited

NullVoxPopuli commented Oct 22, 2021

NullVoxPopuli commented Oct 22, 2021

NullVoxPopuli commented Oct 22, 2021

NullVoxPopuli commented Oct 22, 2021

NullVoxPopuli Oct 22, 2021

Choose a reason for hiding this comment

NullVoxPopuli commented Jan 29, 2022

NullVoxPopuli commented Oct 14, 2021 •

edited

NullVoxPopuli commented Oct 22, 2021 •

edited

NullVoxPopuli commented Oct 22, 2021 •

edited

NullVoxPopuli commented Oct 22, 2021 •

edited