Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Deprecate htmlSafe via prototype #19690

Merged
merged 1 commit into from
Aug 1, 2021

Commits on Aug 1, 2021

  1. [BUGFIX release] Deprecate htmlSafe via prototype

    In Ember 3.24 various string methods added to the `String.prototype` were
    deprecated for removal in Ember 4.0. `htmlSafe` (the version available
    via string prototype) was supposed to be included in those deprecations,
    however dues to its implementation being different it was missed. This
    omission can be understood as a bug.
    
    This patch deprecates `String.prototype.htmlSafe` targeting Ember 4.0.
    This will allow the removal of *all* string prototype extensions in 4.0
    as intended by the original deprecation.
    
    See also: emberjs#19654 (comment)
    mixonic committed Aug 1, 2021
    Configuration menu
    Copy the full SHA
    c6c6978 View commit details
    Browse the repository at this point in the history